[Bug 739992] h264parse: expose compatible profiles to downstream

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Nov 26 07:15:25 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739992
  GStreamer | gst-plugins-bad | git

--- Comment #16 from sreerenj <bsreerenj at gmail.com> 2014-11-26 15:15:20 UTC ---
(In reply to comment #14)
> Review of attachment 291485 [details]:
> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +1212,3 @@
> +      else if (sps->constraint_set0_flag && !sps->constraint_set1_flag)
> +        compat_profile = "baseline";
> +      break;
> 
> I believe the following to be simpler:
> 
> if (csf0) /* A.2.1 */
>   compat_profile = csf1 ? "constrained-baseline" : "baseline";
> else if (csf1) /* A.2.2 */
>   compat_profile = "main";

make sense! will change that.
BTW, i haven't added the S3D profile as a compatible profile of MVC since the
upstream parser is still missing the mvc support. Once this patch get accepted,
i will add the Stereo3D profile thing in vaapiparse_h264 ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list