[Bug 740694] decodebin2: Take STREAM_LOCK before sending sticky events.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740694
  GStreamer | gst-plugins-base | unspecified

Mathieu Duponchelle <mathieu.duponchelle> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-11-26 18:41:39 UTC ---
Author: Mathieu Duponchelle <mathieu.duponchelle at opencreed.com>
Date:   Tue Nov 25 16:46:50 2014 +0100

    decodebin2: Take STREAM_LOCK before sending sticky events.

    There was a race where:

    1) we would put the element to PAUSED
    2) It would get data sent to it from upstream
    3) It would thus send caps
    3) caps_notify_cb would continue autoplugging
    4) caps would flow downstream, the last pad would get exposed
    5) we were still not done sending the sticky events

    Taking the stream lock on the new element's sinkpad and only
    releasing it when sticky events have all been sent prevents
    the caps from reaching the source pad of the element before
    we're all set.

    https://bugzilla.gnome.org/show_bug.cgi?id=740694

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.