[Bug 740787] New: videocrop: No longer apply the new crop if caps have not changed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740787
  GStreamer | gst-plugins-good | git

           Summary: videocrop: No longer apply the new crop if caps have
                    not changed
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: nicolas.dufresne at collabora.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=291602)
 View: https://bugzilla.gnome.org/attachment.cgi?id=291602
 Review: https://bugzilla.gnome.org/review?bug=740787&attachment=291602

videocrop: Make sure new crop is applied

Since "basetransform: Fix caps equality check" commit a7f357,
set_info() will not be called anymore if crop didn't change
the caps. This patch fixes it by remembering if crop needed to
be applied. This check if made in transform_caps, so during
negotiation to avoid the race.

Some note about the fix, it does not fix the race that always existed when
calling set_property() in between transform_caps() and set_info() (one need to
use a pad probe to make it work). It also does not fix that this element may
fail without using GST_ELEMENT_ERROR().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.