[Bug 740790] hlsdemux: Provide EXT-X-PROGRAM-DATE-TIME as a tag event.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740790
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291603|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-27 09:13:47 UTC ---
Review of attachment 291603:
 --> (https://bugzilla.gnome.org/review?bug=740790&attachment=291603)

This probably breaks the unit test btw

::: ext/hls/gsthlsdemux.c
@@ +563,3 @@
+            gst_date_time_unref (prog_dt);
+            prog_dt = gst_date_time_new_from_g_date_time (pdt_new);
+            g_date_time_unref (pdt_new);

Do this conversion already in m3u8.c

@@ +2192,3 @@
   if (!gst_m3u8_client_get_next_fragment (demux->client, &discont,
+          &next_fragment_uri, &demux->prog_datetime, &duration, &timestamp,
+          &range_start, &range_end, &key, &iv, demux->segment.rate > 0)) {

Here just store a "pending_tags" taglist somewhere, and push it downstream on
the next opportunity (i.e. if there is a srcpad)

::: ext/hls/m3u8.c
@@ +109,3 @@
 static GstM3U8MediaFile *
+gst_m3u8_media_file_new (gchar * uri, gchar * title,
+    GstDateTime * program_datetime, GstClockTime duration, guint sequence)

Maybe instead of passing title, datetime and more things in the future here...
just pass a GstTagList with those things?

@@ +117,3 @@
   file->title = title;
+  file->program_datetime =
+      program_datetime ? gst_date_time_ref (program_datetime) : NULL;

And also only store a taglist here

@@ +955,3 @@
+    gboolean * discontinuity, gchar ** uri, GstDateTime ** program_datetime,
+    GstClockTime * duration, GstClockTime * timestamp, gint64 * range_start,
+    gint64 * range_end, gchar ** key, guint8 ** iv, gboolean forward)

And also only return a taglist here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.