[Bug 740686] audio: Error not handled in gst_audio_decoder_drain

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740686
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291456|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-27 10:28:34 UTC ---
Review of attachment 291456:
 --> (https://bugzilla.gnome.org/review?bug=740686&attachment=291456)

::: gst-libs/gst/audio/gstaudiodecoder.c
@@ +1455,3 @@
     ret = gst_audio_decoder_output (dec, NULL);
+    if (ret != GST_FLOW_OK)
+      goto drain_failed;

I think in both "goto drain_failed" cases you still want to go through the
lines below here: clear the adapter and the list of frames.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.