[Bug 740768] videoaggregator: Expose vmethods to set converters and prepare frames

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740768
  GStreamer | gst-plugins-bad | unspecified

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-27 16:25:12 UTC ---
Review of attachment 291635:
 --> (https://bugzilla.gnome.org/review?bug=740768&attachment=291635)

::: gst-libs/gst/video/gstvideoaggregator.c
@@ +149,3 @@
+    gst_video_converter_free (pad->priv->convert);
+
+  pad->priv->convert = NULL;

Maybe the converter should actually be public in the pad. Conversion info
already is anyway.

@@ +222,3 @@
+
+    /* We wait until here to set the conversion infos, in case vagg->info
changed */
+    if (pad->need_conversion_update) {

This seems wrong. If the info changes between this and setting up the converter
above, then the converter will fail to convert.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.