[Bug 739992] h264parse: expose compatible profiles to downstream

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Nov 28 02:13:17 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739992
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291569|none                        |reviewed
             status|                            |

--- Comment #20 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-28 10:13:12 UTC ---
Review of attachment 291569:
 --> (https://bugzilla.gnome.org/review?bug=739992&attachment=291569)

::: gst/videoparsers/gsth264parse.c
@@ +1275,3 @@
+      gst_value_init_and_copy (&profiles, value);
+
+    compat_profile = get_compatible_profile (&profiles, sps);

Are there not multiple compatible profiles?
E.g. a constrained-baseline stream is also a valid baseline, main, high*, etc
stream?

You could just add them all, intersect with what downstream can do, then fixate
the caps.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list