[Bug 740784] subparse: fails to detect UTF-8 encoding

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740784
  GStreamer | gst-plugins-base | git

--- Comment #10 from Athanasios Oikonomou <athoik at gmail.com> 2014-11-29 20:10:19 UTC ---
Created an attachment (id=291805)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=291805)
sample srt without bom that fails in the middle of the file

Hello, 


Applying the proposed patched doen't fix the problem with the attached sample.

subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line '137'
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line
'00:13:22,771 --> 00:13:24,764'
subparse gstsubparse.c:843:parse_subrip_time: parsing timestamp '00:13:22,771'
subparse gstsubparse.c:843:parse_subrip_time: parsing timestamp '00:13:24,764'
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line 'Ήδη τον
ζορίζεις να'
subparse gstsubparse.c:465:convert_encoding:<subparse0> invalid UTF-8!
subparse gstsubparse.c:486:convert_encoding:<subparse0> could not convert
string from 'ANSI_X3.4-1968' to UTF-8: Invalid byte sequence in conversion
input
subparse gstsubparse.c:495:convert_encoding:<subparse0> successfully converted
4096 characters from ANSI_X3.4-1968 to UTF-8 , using ISO-8859-15 as fallback
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line 'τα κάνει
όλα μόνος I?I?I?;'
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line ''
subparse gstsubparse.c:1566:handle_buffer:<subparse0> Sending text 'Ήδη τον
ζορίζεις να
τα κάνει όλα μόνος I&#x84;I?I?;', 0:13:22.771000000 + 0:00:01.993000000
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line '138'
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line
'00:13:25,295 --> 00:13:28,077'
subparse gstsubparse.c:843:parse_subrip_time: parsing timestamp '00:13:25,295'
subparse gstsubparse.c:843:parse_subrip_time: parsing timestamp '00:13:28,077'
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line 'I€I?
I»IµI?; IŸ I?I?I±I?I?I¬I? IZIµ I¶I?II?I¶IµI? I?I?I?I?I?I±.'
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line
'I?I?I¬I»IµIYIµ I?I? I±I?I?I?I?I?I?I·I?I?!'
subparse gstsubparse.c:1535:handle_buffer:<subparse0> Parsing line ''
subparse gstsubparse.c:1566:handle_buffer:<subparse0> Sending text 'I€I?
I»IµI&#x82;; I&#x9f; I?I&#x80;I±I?I&#x80;I¬I&#x82; IZIµ I¶I?I&#x81;I?I¶IµI?
I&#x84;I?I&#x80;I?I&#x84;I±.
I&#x94;I?I¬I»IµIYIµ I&#x84;I? I±I?I&#x84;I?I?I?I?I·I&#x84;I?!',
0:13:25.295000000 + 0:00:02.782000000


It works up to the 137 subtitle without problem.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.