[Bug 737616] timedvaluecontrolsource: Add some signals about values changes

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737616
  GStreamer | gstreamer (core) | unspecified

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287446|none                        |accepted-commit_now
             status|                            |

--- Comment #4 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2014-10-01 13:20:14 UTC ---
Review of attachment 287446:
 --> (https://bugzilla.gnome.org/review?bug=737616&attachment=287446)

::: libs/gst/controller/gsttimedvaluecontrolsource.c
@@ +344,1 @@
       g_sequence_remove (iter);

I want g_sequence_steal()

@@ +469,3 @@
+  /**
+   * GstTimedValueControlSource::value-changed
+   * @self: The #GstTimedValueControlSource on which a #GstTimedValue as
changed

s/as/has/

@@ +484,3 @@
+  /**
+   * GstTimedValueControlSource::value-added
+   */

also here and below

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.