[Bug 737984] schrodec: optimize parse logic

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Oct 8 04:12:13 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=737984
  GStreamer | gst-plugins-bad | unspecified

--- Comment #5 from Vineeth <vineeth.tm at samsung.com> 2014-10-08 11:12:10 UTC ---
Hi Luis,
   Thanks for the review.

   The header_read is true only when we return
GST_VIDEO_DECODER_FLOW_NEED_DATA.
   We have read a header and have the number of bytes to read in 'next', but
the adapter does not consist 'next' bytes, then we are asking for more data. In
this scenario we will not read header again.
   In all other cases, we should set header_read to false.

   Perhaps it would make more sense if i add the same in else case?

   if (gst_adapter_available (adapter) < schro_decoder->next) {
     return GST_VIDEO_DECODER_FLOW_NEED_DATA;
   }
   else
     schro_decoder->header_read = FALSE;

Regards,
Vineeth

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list