[Bug 738319] rtpsession: fix Early Feedback Transmission

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738319
  GStreamer | gst-plugins-good | 1.4.1

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288248|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-10-10 19:40:50 UTC ---
Review of attachment 288248:
 --> (https://bugzilla.gnome.org/review?bug=738319&attachment=288248)

More comments about what your changes are meant to do exactly would help, I'm
not following exactly.

::: gst/rtpmanager/rtpsession.c
@@ -3815,3 @@
    */
-  if (sess->total_sources > sess->rtcp_immediate_feedback_threshold &&
-      sess->allow_early == FALSE) {

Why did you remove the check for the immediate feedback threshold ? That will
just prevent sending feedback immediately.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.