[Bug 739281] video-blend: correct improper logic calculations

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Oct 28 03:01:20 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739281
  GStreamer | gst-plugins-base | unspecified

--- Comment #3 from Vineeth <vineeth.tm at samsung.com> 2014-10-28 10:01:16 UTC ---
Hi Luis,
  This logic would have been executed before the changes made for 738984

  in 738984, if x/y is less than 0, it is set to 0.
  Hence this logic will never be executed now. It is basically dead code after
those changes.

  the pipeline i was testing was 
gst-launch-1.0 filesrc location=../wonder.mp4 ! decodebin ! textoverlay
text=text deltax=-2000 ! videoconvert ! ximagesink

  but now in basetextoverlay, xpos will be set to 0. 
  If it was not set as 0,

 then as per the logic present in video-blend 

 if (x < 0) {
    src_width -= -x;
    x = 0;
    xoff = -x;
 }
 src_width would have been calculated as a negative value, which is wrong.


Regards,
Vineeth

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list