[Bug 738013] v4l2allocator: issue with import_userptr() in single-planar API when n_planes > 1

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738013
  GStreamer | gst-plugins-good | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287859|none                        |reviewed
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-10-29 19:56:12 UTC ---
Review of attachment 287859:
 --> (https://bugzilla.gnome.org/review?bug=738013&attachment=287859)

::: sys/v4l2/gstv4l2allocator.c
@@ +1138,3 @@
+    if (V4L2_TYPE_IS_MULTIPLANAR (allocator->type)) {
+      /* TODO Support passing N plane from 1 memory to MPLANE v4l2 format */
+      goto n_mem_missmatch;

This though should really be supported.

@@ +1142,3 @@
+      /* With the single planar API, planes should be contiguous in memory.
+       * TODO: Check that planes are contiguous instead of assuming it's true
?
+       */

Feels like without this part in, it isn't safe to merge that. Please correct me
if I'm wrong.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.