[Bug 734659] qtdemux: Does not properly update base time for non-flushing seeks
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Sep 2 22:34:07 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=734659
GStreamer | gst-plugins-good | git
Thiago Sousa Santos <thiagossantos> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #285192|none |reviewed
status| |
--- Comment #28 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-09-03 05:34:02 UTC ---
Review of attachment 285192:
--> (https://bugzilla.gnome.org/review?bug=734659&attachment=285192)
Looks good, just needs a simplification.
Also it would be good to test if this doesn't break the heavily edited samples
from https://bugzilla.gnome.org/show_bug.cgi?id=345830
::: gst/isomp4/qtdemux.c
@@ +3500,3 @@
+ }
+ }
+ stream->max_segment_position = -1;
Sorry for not mentioning this earlier, but there is already a position tracking
in qtdemux for all streams: qtdemux->segment.position
This is actually what is used to answer the POSITION query. So you can simplify
it here and use that.
@@ +6211,3 @@
stream->stps_present = FALSE;
if ((stream->stss_present =
+ !!qtdemux_tree_get_child_by_type_full (stbl, FOURCC_stss,
Those changes seem to be caused by gst-indent not being consistent, they should
be removed from this patch.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list