[Bug 735844] basetextoverlay/pango: overlay negotiation fails when it should not

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Sep 5 09:53:20 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=735844
  GStreamer | gst-plugins-base | 1.4.1

--- Comment #19 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-09-05 16:53:14 UTC ---
Created an attachment (id=285509)
 View: https://bugzilla.gnome.org/attachment.cgi?id=285509
 Review: https://bugzilla.gnome.org/review?bug=735844&attachment=285509

basetextoverlay: Do not fail the negotiation if query fails

One of these fixes introduced a regression when the allocation query isn't
supported. This patch seems to make it work again, but I didn't test the
original racy issue. So please test this and confirm it is still fixed.

The allocation query failure doesn't mean that the negotiation
has failed as the element can allocate buffers itself.

Instead, only fail if the pads are flushing and the allocation
query failed.

https://bugzilla.gnome.org/show_bug.cgi?id=727255

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list