[Bug 736313] GList node not freed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736313
  GStreamer | gst-devtools | 1.x

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285720|none                        |needs-work
             status|                            |

--- Comment #1 from Thibault Saunier <tsaunier at gnome.org> 2014-09-09 09:28:22 UTC ---
Review of attachment 285720:
 --> (https://bugzilla.gnome.org/review?bug=736313&attachment=285720)

Please could you provide a patch that only frees the GList of criticals issues.

::: validate/gst/validate/gst-validate-runner.c
@@ +178,3 @@
     }
     count++;
+    g_list_free (tmp);

That does not sound correct to me as we do not own the list here, the Runner
does.

@@ +195,3 @@
   gst_validate_printf (NULL, "Pipeline finished, issues found: %u\n", count);
   return ret;
+  g_list_free (criticals);

That's correct indeed.

@@ +196,3 @@
   return ret;
+  g_list_free (criticals);
+  g_list_free (iter);

The iter should not be freed (it will be NULL at that point anyway).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.