[Bug 736252] gdkpixbufdec: packetized mode logic

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736252
  GStreamer | gst-plugins-good | unspecified

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |thiagossantos at gmail.com
     Ever Confirmed|0                           |1

--- Comment #1 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-09-11 18:15:47 UTC ---
(In reply to comment #0)
> To check packetized mode the logic being used is 
> 
>   /* packetised mode? *//* FIXME: shouln't this be fps_d != 0, since 0/1
>    * might be packetised mode but variable framerate */
>   if (filter->in_fps_n != 0) {
> 
> I guess the logic is correct, since if numerator is 0, it will be considered as
> a single image. In that case FIXME should be removed right?

I'd leave the FIXME there, there doesn't seem to be a consensus on how to
detect packetized input atm. Well, one could use the parsed boolean in caps but
I guess this isn't everywhere yet.

> 
> And i am getting confused, with the logic used in pngdec element
> 
>   if (GST_VIDEO_INFO_FPS_N (info) != 1 && GST_VIDEO_INFO_FPS_D (info) != 1)
>     gst_video_decoder_set_packetized (decoder, TRUE);
> 
> Isn't this wrong? 1/1 framerate is also packetized mode right?
> Shouldn't the condition be, to check for numerator != 0, similar to
> gdkpixbufdec?

Yes, this is wrong. Can you provide a fix? I'd keep the FPS_D != 1 check as
this is comparing against the default value of 0/1, meaning that no framerate
was provided in caps (likely).

> 
>   if (GST_VIDEO_INFO_FPS_N (info) != 0 && GST_VIDEO_INFO_FPS_D (info) != 1)
>     gst_video_decoder_set_packetized (decoder, TRUE);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.