[Bug 733444] wavenc does not support more than 2 channel
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Sep 12 04:50:14 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=733444
GStreamer | gst-plugins-good | 1.3.91
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #285642|none |needs-work
status| |
--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-12 11:50:06 UTC ---
Review of attachment 285642:
--> (https://bugzilla.gnome.org/review?bug=733444&attachment=285642)
::: gst/wavenc/gstwavenc.c
@@ +172,3 @@
+use_format_ext (GstWavEnc * wavenc)
+{
+ return wavenc->channels > 2 || wavenc->width > 16;
Why for width > 16 too?
@@ +247,3 @@
+ /* TODO: how to get the number of samples for compressed data? */
+ GST_WRITE_UINT32_LE (header + 8,
+ wavenc->audio_length / (wavenc->width / 8) / wavenc->channels);
Duration query in TIME format, and then with the sample rate
@@ +378,3 @@
wavenc->channels = chans;
wavenc->rate = rate;
+ wavenc->channel_mask = mask;
You need to convert the GStreamer channel mask to the WAV channel mask, and
potentially have to reorder channels (there's convenience API for the latter in
libgstaudio).
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list