[Bug 736939] gl: logical disjunction consecutive return, break statements

Fri Sep 19 00:15:21 PDT 2014

https://bugzilla.gnome.org/show_bug.cgi?id=736939
  GStreamer | gst-plugins-bad | 1.x

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286560|none                        |needs-work
             status|                            |

--- Comment #1 from Matthew Waters <ystreet00 at gmail.com> 2014-09-19 07:15:18 UTC ---
Review of attachment 286560:
 --> (https://bugzilla.gnome.org/review?bug=736939&attachment=286560)

One issue :)

::: gst-libs/gst/gl/gstglfilter.c
@@ -225,3 @@
           && gst_base_transform_is_passthrough (trans))
         return gst_pad_peer_query (GST_BASE_TRANSFORM_SRC_PAD (trans), query);
-      break;

This will fallthrough to the GST_QUERY_CONTEXT case when not in passthrough
mode.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
