[Bug 735131] gltestsrc: Add new patterns
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sun Sep 21 05:19:00 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=735131
GStreamer | gst-plugins-bad | unspecified
Matthew Waters <ystreet00> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #284026|none |needs-work
status| |
--- Comment #2 from Matthew Waters <ystreet00 at gmail.com> 2014-09-21 12:18:57 UTC ---
Review of attachment 284026:
--> (https://bugzilla.gnome.org/review?bug=735131&attachment=284026)
This seems to use graphene without guards.
::: ext/gl/gltestsrc.c
@@ +223,3 @@
+ if (gst_gl_context_get_gl_api (v->context)) {
+
+ graphene_matrix_init_ortho (&projection_matrix, -1, 1, -1, 1, -1, 1);
This initializes to an identity matrix anyway and is not needed.
@@ +230,3 @@
+
+ gl->ClearColor (0.f, 0.f, 0.f, 0.f);
+ gl->Clear (GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
Do we need the clear?
Especially if it is going to be overwritten later by DrawElements.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list