[Bug 737400] videoscale: Lanczos resizing for NV image format
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Sep 26 07:04:03 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=737400
GStreamer | gst-plugins-base | git
--- Comment #8 from Luis de Bethencourt <luis.bg at samsung.com> 2014-09-26 14:03:59 UTC ---
Created an attachment (id=287159)
View: https://bugzilla.gnome.org/attachment.cgi?id=287159
Review: https://bugzilla.gnome.org/review?bug=737400&attachment=287159
fixes as suggested by Nicolas
Thanks Nicolas. They are good suggestions.
Should I split the style changes into a second patch or have it all in this
one? Currently it includes the fixes to avoid recalculating the same value
multiple times.
Like so:
- sum1 += srcline[k*4+0] * tapsline[k]; \
- sum2 += srcline[k*4+1] * tapsline[k]; \
- sum3 += srcline[k*4+2] * tapsline[k]; \
- sum4 += srcline[k*4+3] * tapsline[k]; \
+ l = k * 4; \
+ sum1 += srcline[l] * tapsline[k]; \
+ sum2 += srcline[l + 1] * tapsline[k]; \
+ sum3 += srcline[l + 2] * tapsline[k]; \
+ sum4 += srcline[l + 3] * tapsline[k]; \
And also a few style fixes.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list