[Bug 737127] interleave: interleaving does not respect the channel positions default order

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737127
  GStreamer | gst-plugins-good | git

Antonio Ospite <ao2> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286870|0                           |1
        is obsolete|                            |

--- Comment #3 from Antonio Ospite <ao2 at ao2.it> 2014-09-29 14:35:29 UTC ---
Created an attachment (id=287357)
 View: https://bugzilla.gnome.org/attachment.cgi?id=287357
 Review: https://bugzilla.gnome.org/review?bug=737127&attachment=287357

interleave: interleave samples following the Default Channel  Ordering

Attached a v2 with these changes:
  - using g_qsort_with_data() to sort the channel map
    NOTE, the sorting is done using the foreign keys from pos[].
  - using a static array for the channel map

I was not sure about the second one, but not having a strong opinion, I just
complied to your comments.

BTW, maybe this could have also be done with the audio channels functions from
gst-plugins-base:
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst-libs/gst/audio/audio-channels.h

In fact, a similar channel map is built also in /riff/riff-media.c:
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst-libs/gst/riff/riff-media.c#n1056

However I don't know if I have the motivation to still work on this.

Thanks,
   Antonio

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.