[Bug 747222] New: vtenc: eliminate gst_video_frame_copy on iOS in non-CVPixelBuffer case

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747222

            Bug ID: 747222
           Summary: vtenc: eliminate gst_video_frame_copy on iOS in
                    non-CVPixelBuffer case
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Mac OS
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: ilya.konstantinov at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In gst_vtenc_encode_frame, we do:

    meta = gst_buffer_get_core_media_meta (frame->input_buffer);
    if (meta != NULL) {
      pbuf = gst_core_media_buffer_get_pixel_buffer (frame->input_buffer);
    }
  #ifdef HAVE_IOS
    if (pbuf == NULL) {
      ...

      /* FIXME: iOS has special stride requirements that we don't know yet.
       * Copy into a newly allocated pixelbuffer for now. Probably makes
       * sense to create a buffer pool around these at some point.
       */

      ...

      if (!gst_video_frame_copy (&outframe, &inframe)) {
      ...

The gst_video_frame_copy is a performance issue.

---

Case in point, in OpenWebRTC we have avfvideosrc upstream, so the pixel layout
should be Apple-compatible. The need for this gst_video_frame_copy should be
reevaluated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.