[Bug 747220] aggregator: Does not unlock sink pads on downstream error

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747220

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300788|none                        |reviewed
             status|                            |

--- Comment #6 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 300788:
 --> (https://bugzilla.gnome.org/review?bug=747220&attachment=300788)

Apart from those 2 comments, looks good.

::: gst-libs/gst/base/gstaggregator.c
@@ -1802,3 @@
   PAD_FLUSH_LOCK (aggpad);

-  if (g_atomic_int_get (&aggpad->priv->flushing) == TRUE)

I do not recall the exact case, but that was necessary in some corner cases.

@@ -1905,3 @@
     PAD_LOCK (aggpad);

-    if (g_atomic_int_get (&aggpad->priv->flushing) == TRUE

Same here, I am pretty sure that this code path is necessary.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.