[Bug 747220] aggregator: Does not unlock sink pads on downstream error

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747220

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300789|none                        |reviewed
             status|                            |

--- Comment #8 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 300789:
 --> (https://bugzilla.gnome.org/review?bug=747220&attachment=300789)

::: gst-libs/gst/base/gstaggregator.c
@@ +632,2 @@
 static void
+gst_aggregator_pad_set_flushing (GstAggregatorPad * aggpad,

Naming is weird, it is not really setting to flushing as it also sets the
FlowReturn now.

@@ +691,3 @@
     GST_LOG_OBJECT (self, "flow return is %s", gst_flow_get_name
(flow_return));

+    if (flow_return != GST_FLOW_OK) {

I am not sure we should use an iterator here as if a pad gets added meanwhile
its flow return will be set before it has a chance to do anything. I have the
impression it would be better to take the object lock and iterate normally.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.