[Bug 747293] audiodecoder: Add sink and src query virtual method

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 3 03:17:21 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=747293

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300876|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 300876
  --> https://bugzilla.gnome.org/attachment.cgi?id=300876
audiodecoder: Add sink and src query virtual method

>-      if (!(res = gst_audio_encoded_audio_convert (&dec->priv->ctx.info,
>+      if (!(res = gst_audio_encoded_audio_convert (&decoder->priv->ctx.info,

It looks like your patch is larger than necessary because you chose to call the
decoder variable 'decoder' instead of 'dec' in the query_default function,
which necessitates unrelated changes. Please rename it to 'dec' in order to
minimise the diff.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list