[Bug 740575] Fixing DTS in GStreamer

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 3 17:09:08 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=740575

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300922|none                        |needs-work
             status|                            |

--- Comment #56 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 300922:
 --> (https://bugzilla.gnome.org/review?bug=740575&attachment=300922)

This patch does not work. It produce broken files. I don't think because CTTS
can be negative that it's fine to make it negative. Also, I notice this
first_pts code that should have been removed when ported to collect pad running
time clip function. Running starts at zero, no need to reset to zero again.
After this cleanup it should be eayser to integrate negative PTS, note that the
sign should be passed along with the buffer somehow.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list