[Bug 747321] New: gstbasesrc: do not leak pool in error cases

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747321

            Bug ID: 747321
           Summary: gstbasesrc: do not leak pool in error cases
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: ilya.konstantinov at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In gst_base_src_decide_allocation_default:

        if (!gst_buffer_pool_set_config (pool, config))
          goto config_failed;
  ...

  if (pool) {
    ...
    gst_object_unref (pool);
  }

  return TRUE;

config_failed:
  config_failed:
    GST_ELEMENT_ERROR (basesrc, RESOURCE, SETTINGS,
        ("Failed to configure the buffer pool"),
        ("Configuration is most likely invalid, please report this issue."));
    return FALSE;

The pool is ref'd so it'll be leaked upon goto to config_failed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.