[Bug 747352] applemedia: texture cache negotiation doesn't work

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747352

--- Comment #16 from Matthew Waters <ystreet00 at gmail.com> ---
(In reply to Ilya Konstantinov from comment #15)
> (In reply to Nicolas Dufresne (stormer) from comment #14)
> > Review of attachment 300967 [details] [review] [review]:
> > 
> > This will cause tearing. We have no control on exactly when the texture will
> > actually be used.
> 
> The texture that's used in the drawing routine is
> glimage_sink->stored_buffer. I'm merely nullifying next_buffer earlier (and
> unrefing once), not changing any behavior.

Removing the ref will cause flickering and possible reading invalid textures. 
An extensive reason as to why it's needed is available in
5b8d7a443ead269d034401a6788f2d47f8fa4bc5 glupload: provide the output buffer
that is rendered into.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.