[Bug 747505] New: vp8 decoding deadline should be specified in us instead of ms

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747505

            Bug ID: 747505
           Summary: vp8 decoding deadline should be specified in us
                    instead of ms
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Mac OS
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: c at ijsf.nl
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Just noticed something in gstvp8dec.c:

  deadline = gst_video_decoder_get_max_decode_time (decoder, frame);
  if (deadline < 0) {
    decoder_deadline = 1;
  } else if (deadline == G_MAXINT64) {
    decoder_deadline = 0;
  } else {
    decoder_deadline = MAX (1, deadline / GST_MSECOND);
  }
  status = vpx_codec_decode (&dec->decoder,
      minfo.data, minfo.size, NULL, decoder_deadline);

I am assuming the decoder_deadline is in milliseconds here, given the division.
The libvpx docs mention the following:

deadline: Soft deadline the decoder should attempt to meet, in us. Set to zero
for unlimited.

Also see http://www.webmproject.org/docs/vp8-sdk/group__decoder.html

This basically implies that the deadline is a factor of 1000 off. Could anyone
verify this?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.