[Bug 747534] Add deadline option to gstvp8dec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747534

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301163|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 301163:
 --> (https://bugzilla.gnome.org/review?bug=747534&attachment=301163)

I'm curious why the default doesn't work? It should try to push it in time for
the sink ?

::: ext/vpx/gstvp8dec.c
@@ +232,3 @@
+    case PROP_DEADLINE:
+      dec->deadline = g_value_get_int64 (value);
+      break;

Please also add the counterpart to get_property()

@@ +528,3 @@

+  if (dec->deadline) {
+    // Deadline is overwritten by property

Pleaser no C++ comment, use /* */ comments instead.

::: ext/vpx/gstvp8dec.h
@@ +39,3 @@
 #endif

+#include <vpx/vpx_encoder.h>

Why include the encoder header here ?!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.