[Bug 747611] inputselector: fix leak in gst_selector_pad_chain()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747611

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301265|none                        |committed
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 301265:
 --> (https://bugzilla.gnome.org/review?bug=747611&attachment=301265)

Thanks for the patch, pushed.

commit b15e6f4bf018b92952bfecf9a94c2cbceb6e29ea
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Fri Apr 10 12:32:27 2015 +0200

    inputselector: fix cached buffer leak in chain function

    gst_selector_pad_chain() was popping cached buffers out of the queue
without
    freeing those. Make sure we don't steal the GstBuffer as the cached buffer
ref
    has been passed to the pad chain function.

    This can be reproduced by running the
    validate.file.playback.switch_subtitle_track_while_paused.test5_mkv
scenario
    with Valgrind.

    https://bugzilla.gnome.org/show_bug.cgi?id=747611

    Signed-off-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.