[Bug 745937] multiqueue: enters the buffering state when the use-buffering property is set

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745937

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301243|none                        |committed
             status|                            |

--- Comment #3 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 301243:
 --> (https://bugzilla.gnome.org/review?bug=745937&attachment=301243)

commit 0ad06434daae08fea343741de1fa8fc386f52808
Author: Duncan Palmer <dpalmer at digisoft.tv>
Date:   Tue Mar 10 12:57:44 2015 +1000

    multiqueue: Don't automatically enter the buffering state when
use-buffering is set.

    There is no reason I can see to set mq->buffering = TRUE when
    use_buffering is set; the code here also calls update_buffering(), which
    will set mq->buffering = TRUE if this is warranted because of low buffer
    levels.

    https://bugzilla.gnome.org/show_bug.cgi?id=745937

--- Comment #4 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 301243:
 --> (https://bugzilla.gnome.org/review?bug=745937&attachment=301243)

commit 0ad06434daae08fea343741de1fa8fc386f52808
Author: Duncan Palmer <dpalmer at digisoft.tv>
Date:   Tue Mar 10 12:57:44 2015 +1000

    multiqueue: Don't automatically enter the buffering state when
use-buffering is set.

    There is no reason I can see to set mq->buffering = TRUE when
    use_buffering is set; the code here also calls update_buffering(), which
    will set mq->buffering = TRUE if this is warranted because of low buffer
    levels.

    https://bugzilla.gnome.org/show_bug.cgi?id=745937

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.