[Bug 747730] New: osx: fails to build tests/examples/streams/rtpool-test

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747730

            Bug ID: 747730
           Summary: osx: fails to build tests/examples/streams/rtpool-test
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Mac OS
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: julien.isorce at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

It fails with "clang: error: argument unused during compilation: -pthread"
because -pthread option is only accepted by the compiler, not the linker. Also
see http://stackoverflow.com/questions/17841140/os-x-clang-pthread .
clangs --help | grep pthread: "-pthread   Support POSIX threads in generated
code"

PTHREAD_LIBS does not contain -pthread, only PTHREAD_CFLAGS contains -pthread.
But the problem is that automake passes rtpool_test_CFLAGS to the linker:

rtpool_test_LINK = $(LIBTOOL) $(AM_V_lt) --tag=CC $(AM_LIBTOOLFLAGS) \
        $(LIBTOOLFLAGS) --mode=link $(CCLD) $(rtpool_test_CFLAGS) \
        $(CFLAGS) $(AM_LDFLAGS) $(LDFLAGS) -o $@

rtpool-test$(EXEEXT): $(rtpool_test_OBJECTS) $(rtpool_test_DEPENDENCIES)
$(EXTRA_rtpool_test_DEPENDENCIES)
        @rm -f rtpool-test$(EXEEXT)
        $(AM_V_CCLD)$(rtpool_test_LINK) $(rtpool_test_OBJECTS)
$(rtpool_test_LDADD) $(LIBS)

So in the end -pthread is passed to the linker which result to an error.
We could argue to just remove -Werror but maybe it's better to find a way to
avoid forwarding -pthread to the linker, see following patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.