[Bug 747757] winks: add GstDeviceProvider implementations on Windows

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747757

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301434|none                        |reviewed
             status|                            |

--- Comment #4 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 301434:
 --> (https://bugzilla.gnome.org/review?bug=747757&attachment=301434)

Generally looks good. Did you test with gst-device-monitor-1.0 and
"gst-device-monitor-1.0 -f" and plug/unplug a couple devices?

::: sys/winks/ksdeviceprovider.c
@@ +490,3 @@
+  GST_OBJECT_LOCK (self);
+  GST_DEBUG_OBJECT (self, "Exiting internal window thread: %p",
+      g_thread_self ());

Why take the lock here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.