[Bug 747829] rtpsession: Forward stream-start events to send_rtcp srcpad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747829

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301514|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301514:
 --> (https://bugzilla.gnome.org/review?bug=747829&attachment=301514)

::: gst/rtpmanager/gstrtpsession.c
@@ +1898,3 @@
+      gst_event_ref (event);
+      ret = gst_pad_push_event (rtpsession->send_rtp_src, event);
+      if (rtpsession->send_rtcp_src) {

Why do you check for NULL after using it in the line before?

Also why do you send caps and segment event here too, and not as part of the
actual segment events that arrive later? Also what about other events, like
EOS?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.