[Bug 747839] gst-rtsp-server: Doesn't perfrom retransmission to both streams in test-video-rtx.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747839

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Hyunjun from comment #0)
> There are 2 problems.
> 
> 1. Duplicated call of g_signal_connect
> During start-up of test-video-rtx, it makes signal handler by code below.
> - g_signal_connect (rtpbin, "request-aux-sender", (GCallback)
> request_aux_sender, stream);
> In case of 2 streams, in the second call of request_aux_sender, userdata is
> not the second stream but the first stream, which is previous stream.
> Even though it makes another aux sender bin, but it's not doing
> retransmission because rtx_pt_map is same as the first aux sender.
> In this case, signal handler needs to be removed, and makes new handler.

Passing the stream there seems wrong then, instead it should pass the media or
something and get the relevant streams from it later.

> 2. In case that payload type is different.
> In this test-code, it makes pipeline with PCMA payloader, which has "pt=97"
> But it's changed to 8 later according to spec. 
> Because of this, audio retransmission always failed. Audio's aux sender has
> wrong rtx_pt_map.
> IMHO, rtx_pt_map has to be updated in this case. But I'm not sure it's valid.

Yes, it would have to be updated. Where exactly is it changed from 97 to 8
later, and how can we know that inside the rtsp server?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.