[Bug 747839] gst-rtsp-server: Doesn't perfrom retransmission to both streams in test-video-rtx.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747839

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Hyunjun from comment #2)
> > Passing the stream there seems wrong then, instead it should pass the media > or something and get the relevant streams from it later.
> IMHO, there is nothing which has both streams' information to pass instead
> of stream. Because rtsp-stream has information for each stream.
> 
> How about reset signal handler in each stream like below?
> 
> signal_id = g_signal_lookup ("request-aux-sender", G_OBJECT_TYPE (rtpbin));
> 
>     /* If there's already signal handler for another stream, it needs to be
> removed */
>     if ((sig_handler_id =
>             g_signal_handler_find (rtpbin, G_SIGNAL_MATCH_ID, signal_id, 0,
>                 NULL, NULL, NULL)) != 0) {
>       GST_DEBUG_OBJECT (stream, "disconnect previous stream's signal
> handler");
>       g_signal_handler_disconnect (rtpbin, sig_handler_id);
>     }

I don't think that's a good idea, it's not guaranteed that the signal was
already emitted at this point with the other stream.

> > Yes, it would have to be updated. Where exactly is it changed from 97 to 8 later, and how can we know that inside the rtsp server?
> 
> There is caps_notify callback for signal "notify::caps" from recv_rtp_sink
> pad. I think I can use this callback to update pt info.

Seems reasonable

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.