[Bug 747830] gst-validate-launcher --sync performs tests when annex failed

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747830

Hyung Song <beergun81 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Hyung Song <beergun81 at gmail.com> ---
(In reply to Thibault Saunier from comment #7)
> (In reply to Hyung Song from comment #6)
> > (In reply to Thibault Saunier from comment #5)
> > > (In reply to Hyung Song from comment #3)
> > > > With this patch applied, testsuite becomes empty and running another
> > > > 'gst-validate-launcher --sync' has no test to perform.
> > > 
> > > Isn't that the expected behaviour? If we can't sync we should just exit.
> > > 
> > 
> > Before exiting, message is printed for removing each test case and testsuite
> > becomes empty. To rollback testsuite I'm removing gst-validate directory
> > before 'gst-validate-launcher --sync'.
> 
> Ah, ok I understand what you are talking about now. It does not remove any
> test, the list of test not being run is just informative to the user to let
> him now something changed/something went wrong. If you install git annex and
> --sync again, you will get the media files and it will afterward print the
> list of now 'added' tests.
> 
> > > (In reply to Hyung Song from comment #4)
> > > > In main.py:
> > > > 
> > > >     tests_launcher.set_settings(options, [])
> > > > ...
> > > >     tests_launcher.list_tests()
> > > > 
> > > > If there's a way to check if testsuite is not loaded, then exit before
> > > > list_tests()?
> > > 
> > > What would that bring us? (from what I understand it would be a very minor
> > > optimization in the failure case)
> > 
> > Removing test cases in the testsuite seems to happen in list_tests.
> 
> As I explained previously no tests are removed, it is just a notification to
> the user.

I understand. Thank you very much!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.