[Bug 747394] rtpsession: Track RTX ssrc caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747394

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301000|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301000:
 --> (https://bugzilla.gnome.org/review?bug=747394&attachment=301000)

::: gst/rtpmanager/gstrtprtxsend.c
@@ +594,2 @@
       gst_event_parse_caps (event, &caps);
+      gst_event_unref (event);

After this the caps are not valid anymore

@@ +605,3 @@

+      /* The session might need to know the RTX ssrc */
+      caps = gst_caps_make_writable (caps);

The event usually owns the one and only reference to the caps, so you need to
explicitly copy them above before unreffing the event

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.