[Bug 747839] gst-rtsp-server: Doesn't perfrom retransmission to both streams in test-video-rtx.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747839

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301533|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301533:
 --> (https://bugzilla.gnome.org/review?bug=747839&attachment=301533)

::: gst/rtsp-server/rtsp-media.c
@@ +2448,3 @@
+
+  streams = (GPtrArray *) userdata;
+  stream = g_ptr_array_index (streams, sessid);

I don't think the index is always the same as the session id. You'll have to
iterate over all streams and check their index via gst_rtsp_stream_get_index()

@@ +2472,3 @@
+      /* enable retransmission by setting rtprtxsend as the "aux" element of
rtpbin */
+      g_signal_connect (priv->rtpbin, "request-aux-sender",
+          (GCallback) request_aux_sender, priv->streams);

The streams array has to be protected by a mutex. Maybe just pass the
GstRTSPMedia* here, then take the mutex in the signal handler and then access
the streams.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.