[Bug 747757] winks: add GstDeviceProvider implementations on Windows

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747757

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier.crete at ocrete.ca

--- Comment #6 from Olivier Crête <olivier.crete at ocrete.ca> ---
(In reply to LRN from comment #5)
> (In reply to Olivier Crête from comment #4)
> > Review of attachment 301434 [details] [review] [review]:
> > 
> > Generally looks good. Did you test with gst-device-monitor-1.0 and
> > "gst-device-monitor-1.0 -f" and plug/unplug a couple devices?
> I only have one webcamera, and i tested *that*. I could probably hook it up
> to a laptop to test addition and removal of a second device, but, obviously,
> can't remove the built-in one at runtime.

That's already a good test, thank you !

> > ::: sys/winks/ksdeviceprovider.c
> > @@ +490,3 @@
> > +  GST_OBJECT_LOCK (self);
> > +  GST_DEBUG_OBJECT (self, "Exiting internal window thread: %p",
> > +      g_thread_self ());
> > 
> > Why take the lock here?
> 
> Well, i thought that you lock self whenever you use self. GST_DEBUG_OBJECT()
> takes self, so i lock.

For GST_DEBUG,etc_OBJECT() macros you don't need to take the lock.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.