[Bug 747852] pad: idle probe doesn't block pad from pushing data

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747852

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301572|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301572:
 --> (https://bugzilla.gnome.org/review?bug=747852&attachment=301572)

::: gst/gstpad.c
@@ +1395,3 @@
       /* Keep another ref, the callback could destroy the pad */
       gst_object_ref (pad);
+      pad->priv->idle_running++;

Can this ever be bigger than 1?

@@ +3449,3 @@
       (info->type & GST_PAD_PROBE_TYPE_BLOCK) == GST_PAD_PROBE_TYPE_BLOCK;

+  do_pad_idle_probe_wait (pad);

Maybe you want to do something with the return value here, but otherwise this
makes sense :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.