[Bug 747892] validate:launcher: Handle git error properly

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Apr 15 01:57:23 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=747892

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301595|none                        |needs-work
             status|                            |

--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 301595:
 --> (https://bugzilla.gnome.org/review?bug=747892&attachment=301595)

::: validate/tools/gst-validate-launcher.in
@@ +31,3 @@
         os.chdir(path)
         res = subprocess.check_output(['git', 'rev-list', '--max-parents=0',
'HEAD']).rstrip('\n')
+    except:

Would be better to also catch OSError instead of just accepting any exception.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list