[Bug 747610] Inconsistent bin children state when a child fails to switch from NULL to READY

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747610

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301611|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301611:
 --> (https://bugzilla.gnome.org/review?bug=747610&attachment=301611)

::: gst/gstbin.c
@@ +2651,3 @@
+   * up, we need to switch those elements back down to the previous state to
be
+   * in sync with the bin */
+  changed_elements = NULL;

Why not just set the state to the previous one for *all* elements. No need to
remember the ones that were successful IMHO, that's just making things more
complicated everywhere for an error case.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.