[Bug 746209] Merge glfiltersobel, glfilterblur and glfilterlaplacian into gleffects

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746209

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301013|none                        |needs-work
             status|                            |

--- Comment #21 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 301013:
 --> (https://bugzilla.gnome.org/review?bug=746209&attachment=301013)

Thx for the patch, just a few cleanup required.

::: ext/gl/effects/gstgleffectsobel.c
@@ +55,3 @@
+    gst_gl_shader_set_uniform_1i (shader, "tex", 0);
+    gst_gl_shader_set_uniform_1f (shader, "width", width);
+    gst_gl_shader_set_uniform_1f (shader, "height", height);

These 2 lines are should be removed.

@@ +90,3 @@
+    gst_gl_shader_set_uniform_1i (shader, "tex", 0);
+    gst_gl_shader_set_uniform_1f (shader, "width", width);
+    gst_gl_shader_set_uniform_1f (shader, "height", height);

This 1 line should be removed.

@@ +124,3 @@
+
+    gst_gl_shader_set_uniform_1i (shader, "tex", 0);
+    gst_gl_shader_set_uniform_1f (shader, "width", width);

This line should be removed.

@@ +160,3 @@
+    gst_gl_shader_set_uniform_1i (shader, "tex", 0);
+    gst_gl_shader_set_uniform_1f (shader, "width", width);
+    gst_gl_shader_set_uniform_1f (shader, "height", height);

These 2 lines should be removed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.