[Bug 747610] Inconsistent bin children state when a child fails to switch from NULL to READY

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747610

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301618|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301618:
 --> (https://bugzilla.gnome.org/review?bug=747610&attachment=301618)

Looks generally good, but please also a unit test :)

::: gst/gstbin.c
@@ +2545,3 @@
+{
+  GstElement *e = g_value_get_object (data);
+  GstState state = (GstState) user_data;

GPOINTER_TO_INT()

Otherwise this will give compiler warnings on weird compilers/platforms :)

@@ +2547,3 @@
+  GstState state = (GstState) user_data;
+
+  gst_element_set_state (e, state);

Maybe check return value here and print something if things go wrong

@@ +2830,3 @@
+          gst_element_state_get_name (current));
+      do {
+        ret = gst_iterator_foreach (it, &reset_state, (gpointer) current);

GINT_TO_POINTER()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.