[Bug 747610] Inconsistent bin children state when a child fails to switch from NULL to READY

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747610

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301624|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301624:
 --> (https://bugzilla.gnome.org/review?bug=747610&attachment=301624)

::: tests/check/generic/states.c
@@ +232,3 @@
+
+  /* we want at least one before and one after */
+  g_assert (G_N_ELEMENTS (mid) >= 3);

But you just created it with 3 elements 5 lines above :)

@@ +254,3 @@
+
+  /* make the middle element fail to switch up */
+  GST_ELEMENT_GET_CLASS (mid[1])->change_state = fail_to_go_to_ready;

Here you're changing change_state for all identity elements... not just your 3,
but all that are ever created in the same process from this point onwards.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.