[Bug 747610] Inconsistent bin children state when a child fails to switch from NULL to READY

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747610

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301640|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301640:
 --> (https://bugzilla.gnome.org/review?bug=747610&attachment=301640)

::: tests/check/generic/states.c
@@ +259,3 @@
+  /* make the middle element fail to switch up */
+  identity_state_change = GST_ELEMENT_GET_CLASS (mid[1])->change_state;
+  GST_ELEMENT_GET_CLASS (mid[1])->change_state = fail_to_go_to_ready;

No, use state-error=null-to-ready on the fakesink

Otherwise if your test fails, the vfunc will be wrong for all future fakesinks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.