[Bug 747610] Inconsistent bin children state when a child fails to switch from NULL to READY

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747610

Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1

--- Comment #20 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
Yes, I had been testing both on each update :)

Thanks.

commit a3b42ec42a085f4767930f55d5bb0b4f4fc8321a
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Wed Apr 15 11:02:54 2015 +0100

    bin: undo upward state changes on children when a child fails

    When a bin changes states upwards, and a child fails to change,
    any child that was already switched will not be reset to its
    original state, leaving its state inconsistent with the bin,
    which does not change state due to the failure.

    If the state change was from NULL to READY, it means that deleting
    this bin will cause those children to be deleted while not in
    NULL state, which is a Bad Thing. For other upward changes, it
    is less of a problem, as a subsequent switch back to NULL will
    cause an actual downwards change on those inconsistent elements,
    albeit from the "wrong" state.

    We now reset state to the original one when a child fails.

    Includes unit test.

    https://bugzilla.gnome.org/show_bug.cgi?id=747610

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.